[Rawstudio-users] Fedora package update

giallu at gmail.com giallu at gmail.com
Tue Feb 22 08:37:19 CET 2011


On Mon, Feb 21, 2011 at 12:50 PM, Klaus Post <klauspost at gmail.com> wrote:
> Hi!
>
> Trunk should be quite stable by now. We are preparing for an official
> release, so features are only being updated to fix bugs and usability
> issues.

Great. I'm updating packages now and hitting a minor issue I'd like to
note here. Fedora 15 is being built with gcc 4.6 and the new compiler
brings a change were warning are issued when variables are being
declared, then assigned once, then never used again.

It finds some:
rs-icc-profile.c: In function 'read_from_memory':
rs-icc-profile.c:317:8: error: variable 'tag_size' set but not used
[-Werror=unused-but-set-variable]

Then others in rs-filter.c,
rs-filter.c: In function 'rs_filter_get_image':
rs-filter.c:257:8: warning: variable 'ih' set but not used
[-Wunused-but-set-variable]
rs-filter.c:256:8: warning: variable 'iw' set but not used
[-Wunused-but-set-variable]
rs-filter.c: In function 'rs_filter_get_image8':
rs-filter.c:353:8: warning: variable 'ih' set but not used
[-Wunused-but-set-variable]
rs-filter.c:352:8: warning: variable 'iw' set but not used
[-Wunused-but-set-variable]
rs-filter.c: In function 'rs_filter_graph':
rs-filter.c:750:7: warning: variable 'ignore' set but not used
[-Wunused-but-set-variable]

and rs-library.c
rs-library.c: In function 'rs_library_search':
rs-library.c:712:7: warning: variable 'rc' set but not used
[-Wunused-but-set-variable]
rs-library.c: In function 'rs_library_photo_tags':
rs-library.c:902:7: warning: variable 'rc' set but not used
[-Wunused-but-set-variable]
rs-library.c: In function 'rs_library_restore_tags':
rs-library.c:1078:7: warning: variable 'version' set but not used
[-Wunused-but-set-variable]

The build stops because it is run with -Werror so, for now, I'm just
disabling the flag; you may want to analyze and issue a better fix for
the code.

Thanks again

G.

-- 
Gianluca Sforna

http://morefedora.blogspot.com
http://identi.ca/giallu - http://twitter.com/giallu



More information about the Rawstudio-users mailing list