[Rawstudio-dev] [PATCH] sparse spotted errors and warnings

Edouard Gomez ed.gomez at free.fr
Wed Jan 3 19:25:54 CET 2007


Anders Brander (anders at brander.dk) wrote:
> >  - declare extern functions that are meant to be extern
> 
> What would we gain by doing this? Doesn't all compilers default to
> extern for function prototypes?

They should be. But for some  reason that i ignore, sparse authors think
that it's clearer to explicitly mark prototypes as extern when it's that
way.

> >  - variables shadowing
> 
> Should be fixed for clarity...

Yup standard allows that, the var scope is supposed to solve any
ambiguity, but still human mind is not a compiler :-)

> > This fixes all spotted errors and warnings as of today. I folded the ~10
> > patches all together to make it easier to apply, if you want to review
> > individual file fixes, ask for the series instead of the folded patch.
> 
> It took quite some time to skim thou, but it was worth it :)

Ok, then i'll delete the series as soon as they get applied

> > +++ b/src/gtk-helper.c	Wed Jan 03 14:24:23 2007 +0100
> > @@ -35,7 +35,7 @@ static void gui_cms_di_profile_button_cl
> >  static void gui_cms_di_profile_button_clicked(GtkButton *button, gpointer user_data);
> >  static void gui_cms_ex_profile_button_clicked(GtkButton *button, gpointer user_data);
> >  
> > -gchar *color_profiles[] = {
> > +static gchar *color_profiles[] = {
> 
> Shouldn't this be const'ed too?

Yeah, they can be.

-- 
Edouard Gomez



More information about the Rawstudio-dev mailing list